FailedChanges

Summary

  1. Went through the api test classes and test definition classes, looked them over for problems, and added comments.
  2. MNv1AuthTestDefinitions and MNv2ReadTestDefinitions, containing the systemMetadataChanged test methods were put into MNSystemMetadataChangedTestDefinitions, applied to MNAuthV1IT, removed from MNReadV2IT, and added to MNReplicationV2IT. Implementation of the systemMetadataChanged test methods was moved into MNReplicationImplementations. The getLogRecords test methods were in a separate integration test class for MNs originally because they would take longer to run and we wanted to be able to run them separately. I moved them from CoreTestDefinitions into CNCoreTestDefinitions and put them in a new MNCoreSlowTestDefinitions interface in order to be able to separate the MN test classes into versions with/without these methods. From MNReplicationTestDefinitions, I removed some test methods which were functional tests, not API tests. Updated the implementing classes to match.
  3. added NodeType to constructed Nodes setup in ContextAwareTestCaseDataone.setup(). to avoid NPEs. restored inheritance of the AbstractAuthorization tests to CATCD1.
  4. Finished creating all the integration test classes and hooking them up to the implementation code. Also fixed a few problems in the existing ones. Added the multi-node test methods to CNReplicationTestImplementations. While writing the IT classes, discovered a mismatch between Node version types in the node iterators vs the call adapter methods. Decided to keep the call adapters using the v2 Node since they call into v2 methods, and made the implementations do conversion if necessary.
Revision 15007 by andreib:
Went through the api test classes and test definition classes, looked them over for problems, and added comments.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNAuthV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNAuthV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNCoreV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNIdentityV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNIdentityV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReadV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReadV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNRegisterV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNRegisterV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReplicationV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReplicationV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNAuthV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNAuthV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNCoreV1SlowIT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNCoreV2SlowIT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNQueryV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNQueryV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReadV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReadV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReplicationV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReplicationV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/AuthTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/CNIdentityTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/CNReadTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/CNv2CoreTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/CoreTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNCoreTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/ReadTestDefinitions.javaN/A
Revision 15006 by andreib:
MNv1AuthTestDefinitions and MNv2ReadTestDefinitions, containing the systemMetadataChanged test methods were put into MNSystemMetadataChangedTestDefinitions, applied to MNAuthV1IT, removed from MNReadV2IT, and added to MNReplicationV2IT. Implementation of the systemMetadataChanged test methods was moved into MNReplicationImplementations.

The getLogRecords test methods were in a separate integration test class for MNs originally because they would take longer to run and we wanted to be able to run them separately. I moved them from CoreTestDefinitions into CNCoreTestDefinitions and put them in a new MNCoreSlowTestDefinitions interface in order to be able to separate the MN test classes into versions with/without these methods.

From MNReplicationTestDefinitions, I removed some test methods which were functional tests, not API tests. Updated the implementing classes to match.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNAuthV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNCoreV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNCoreV1SlowIT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNCoreV2IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNCoreV2SlowIT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReadV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReplicationV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReplicationV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/CNCoreTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/CoreTestDefinitions.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNCoreSlowTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNReadTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNReplicationTestDefinitions.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNSystemMetadataChangedTestDefinitions.javaN/A
The file was removed/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNv1AuthAPITestDefinitions.javaN/A
The file was removed/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testDefinitions/MNv2ReadTestDefinitions.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/MNReadTestImplementations.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/MNReplicationTestImplementations.javaN/A
Revision 15004 by rnahf:
added NodeType to constructed Nodes setup in ContextAwareTestCaseDataone.setup().  to avoid NPEs.  restored inheritance of the AbstractAuthorization tests to CATCD1.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/ContextAwareTestCaseDataone.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/AbstractAuthorizationTestImplementations.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/IsAuthorizedAuthorizationTestImplementations.javaN/A
Revision 15003 by andreib:
Finished creating all the integration test classes and hooking them up to the implementation code. Also fixed a few problems in the existing ones.
Added the multi-node test methods to CNReplicationTestImplementations.
While writing the IT classes, discovered a mismatch between Node version types in the node iterators vs the call adapter methods. Decided to keep the call adapters using the v2 Node since they call into v2 methods, and made the implementations do conversion if necessary.
Change TypePath in RepositoryPath in Workspace
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNIdentityV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNIdentityV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReadV2IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNRegisterV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNRegisterV2IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReplicationV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/CNReplicationV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNAuthV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNQueryV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNQueryV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReadV1IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReadV2IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReplicationV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNReplicationV2IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNStorageV1IT.javaN/A
The file was added/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/apiTests/MNStorageV2IT.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/CNRegisterTestImplementations.javaN/A
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/CNReplicationTestImplementations.javaN/A